Change URL caching inside ThemeLoader. (#2318)

Signed-off-by: Matthias Viranyi <matthias.viranyi@here.com> Co-authored-by: Matthias Viranyi <matthias.viranyi@here.com>
heremaps · Oct 14, 2021 · bd9d86e · bd9d86e
1 parent 0bbc120
commit bd9d86e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/@here/harp-mapview/lib/ThemeLoader.ts b/@here/harp-mapview/lib/ThemeLoader.ts
@@ -25,7 +25,6 @@ import {
     IContextLogger,
     ISimpleChannel,
     RelativeUriResolver,
-    resolveReferenceUri,
     UriResolver
 } from "@here/harp-utils";
 
@@ -136,7 +135,7 @@ export class ThemeLoader {
                 throw new Error(`ThemeLoader#load: cannot load theme: ${response.statusText}`);
             }
             theme = (await response.json()) as Theme;
-            theme.url = resolveReferenceUri(getAppBaseUrl(), themeUrl);
+            theme.url = themeUrl;
             theme = this.resolveUrls(theme, options);
         } else if (theme.url === undefined) {
             // assume that theme url is same as baseUrl

diff --git a/@here/harp-mapview/test/ThemeLoaderTest.ts b/@here/harp-mapview/test/ThemeLoaderTest.ts
@@ -50,12 +50,7 @@ describe("ThemeLoader", function () {
 
         it("resolves absolute theme url of theme loaded from relative url", async function () {
             const result = await ThemeLoader.load(sampleThemeUrl);
-            assert.equal(result.url, resolveReferenceUri(appBaseUrl, sampleThemeUrl));
-        });
-
-        it("resolves absolute url of theme loaded from relative url", async function () {
-            const result = await ThemeLoader.load(sampleThemeUrl);
-            assert.equal(result.url, resolveReferenceUri(appBaseUrl, sampleThemeUrl));
+            assert.equal(result.url, sampleThemeUrl);
         });
 
         it("resolves urls of resources embedded in theme", async function () {