MINOR: Re-enable no-unused-variable tslint option

Signed-off-by: Nino Kettlitz <1396039+ninok@users.noreply.github.com>

@here/harp-datasource-protocol/lib/Extruder.ts

@@ -4,13 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import * as THREE from "three";
-
-const currEdgeStart = new THREE.Vector2();
-const currEdgeGoal = new THREE.Vector2();
-const prevEdgeStart = new THREE.Vector2();
-const prevEdgeGoal = new THREE.Vector2();
-
 /**
  * Fills an index buffer with the indices for the extruded walls for a polygon contour.
  *

@here/harp-geojson-datasource/lib/GeoJsonTile.ts

@@ -18,7 +18,7 @@ import {
     Tile,
     TileObject
 } from "@here/harp-mapview";
-import { ContextualArabicConverter, FontUnit } from "@here/harp-text-canvas";
+import { ContextualArabicConverter } from "@here/harp-text-canvas";
 import * as THREE from "three";
 import {
     GeoJsonPoiGeometry,

@here/harp-geometry/test/SphericalGeometrySubdivisionModifierTest.ts

@@ -15,8 +15,6 @@ import * as THREE from "three";
 
 import * as geo from "@here/harp-geoutils";
 
-import * as fs from "fs";
-
 describe("SphericalGeometrySubdivisionModifier", function() {
     it("SubdivideTileBounds", function() {
         const geoPoint = new geo.GeoCoordinates(53.3, 13.4);

@here/harp-mapview-decoder/lib/WorkerServiceManager.ts

@@ -5,11 +5,8 @@
  */
 
 import { WorkerServiceProtocol } from "@here/harp-datasource-protocol";
-import { LoggerManager } from "@here/harp-utils";
 import { WorkerService, WorkerServiceResponse } from "./WorkerService";
 
-const logger = LoggerManager.instance.create("WorkerServiceManager");
-
 /**
  * Factory function that creates [[WorkerService]].
  */

@here/harp-mapview/lib/MapView.ts

@@ -14,7 +14,6 @@ import { IMapAntialiasSettings, IMapRenderingManager, MapRenderingManager } from
 import { ConcurrentDecoderFacade } from "./ConcurrentDecoderFacade";
 import { CopyrightInfo } from "./CopyrightInfo";
 import { DataSource } from "./DataSource";
-import { ElevationRangeSource } from "./ElevationRangeSource";
 import { MapViewImageCache } from "./image/MapViewImageCache";
 import { MapViewFog } from "./MapViewFog";
 import { PickHandler, PickResult } from "./PickHandler";

@here/harp-mapview/lib/Tile.ts

@@ -1032,18 +1032,6 @@ export class Tile implements CachedResource {
      * @param decodedTile The [[DecodedTile]].
      */
     createTextElements(decodedTile: DecodedTile) {
-        // gather the sum of [[TextElement]]s (upper boundary), to compute the priority, such that
-        // the text elements that come first get the highest priority, so they get placed first.
-        let numTextElements = 0;
-        let numTextElementsCreated = 0;
-
-        if (decodedTile.textPathGeometries !== undefined) {
-            numTextElements += decodedTile.textPathGeometries.length;
-        }
-        if (decodedTile.textGeometries !== undefined) {
-            numTextElements += decodedTile.textGeometries.length;
-        }
-
         const displayZoomLevel = Math.floor(this.mapView.zoomLevel);
         if (decodedTile.textPathGeometries !== undefined) {
             this.m_preparedTextPaths = this.prepareTextPaths(decodedTile.textPathGeometries);
@@ -1109,7 +1097,6 @@ export class Tile implements CachedResource {
                 textElement.reserveSpace = technique.reserveSpace !== false;
 
                 this.addTextElement(textElement);
-                numTextElementsCreated++;
             }
         }
 
@@ -1176,7 +1163,6 @@ export class Tile implements CachedResource {
                     textElement.fadeFar = getPropertyValue(technique.fadeFar, displayZoomLevel);
 
                     this.addTextElement(textElement);
-                    numTextElementsCreated++;
                 }
             }
         }
@@ -1942,20 +1928,6 @@ export class Tile implements CachedResource {
         };
     }
 
-    private getMaterialsCount() {
-        let num = 0;
-        this.objects.forEach((rootObject: TileObject & DisposableObject) => {
-            if (rootObject.material) {
-                if (Array.isArray(rootObject.material)) {
-                    num += rootObject.material.length;
-                } else {
-                    num += 1;
-                }
-            }
-        });
-        return num;
-    }
-
     /**
      * Pass the feature data on to the object, so it can be used in picking
      * `MapView.intersectMapObjects()`. Do not pass the feature data if the technique is a

@here/harp-mapview/lib/VisibleTileSet.ts

@@ -8,7 +8,7 @@ import { LRUCache } from "@here/harp-lrucache";
 import * as THREE from "three";
 
 import { DataSource } from "./DataSource";
-import { CalculationStatus, ElevationRange, ElevationRangeSource } from "./ElevationRangeSource";
+import { CalculationStatus, ElevationRangeSource } from "./ElevationRangeSource";
 import { MapTileCuller } from "./MapTileCuller";
 import { Tile } from "./Tile";
 

@here/harp-mapview/lib/text/TextElementsRenderer.ts

@@ -776,6 +776,7 @@ export class TextElementsRenderer {
                 this.createTextElementStyle(element, element.name!)
             );
         });
+        // tslint:disable-next-line:no-unused-variable
         for (const [name, style] of this.m_textStyles) {
             if (style.textCanvas === undefined) {
                 if (style.fontCatalog !== undefined) {

@here/harp-mapview/lib/text/TextStyleCache.ts

@@ -14,11 +14,6 @@ import {
 } from "@here/harp-text-canvas";
 import { ColorCache } from "../ColorCache";
 
-/**
- * Maximum zoom level possible considered in [[computeStyleCacheId]].
- */
-const MAX_ZOOM_LEVEL = 100;
-
 /**
  * [[TextStyle]] id for the default value inside a [[TextRenderStyleCache]] or a
  * [[TextLayoutStyleCache]].

@here/harp-mapview/test/ConcurrentWorkerSetTest.ts

@@ -3,11 +3,7 @@
  * Licensed under Apache 2.0, see full license in LICENSE
  * SPDX-License-Identifier: Apache-2.0
  */
-import {
-    RequestController,
-    WorkerDecoderProtocol,
-    WorkerServiceProtocol
-} from "@here/harp-datasource-protocol";
+import { WorkerDecoderProtocol, WorkerServiceProtocol } from "@here/harp-datasource-protocol";
 import { stubGlobalConstructor, willEventually } from "@here/harp-test-utils";
 import { Logger, LogLevel, WorkerChannel, WORKERCHANNEL_MSG_TYPE } from "@here/harp-utils";
 import { assert } from "chai";

@here/harp-omv-datasource/lib/OmvDebugLabelsTile.ts

@@ -66,8 +66,6 @@ export class OmvDebugLabelsTile extends OmvTile {
         super.createTextElements(decodedTile);
 
         const colorMap = new Map<number, THREE.Color>();
-        // black color for point numbers
-        const black = new THREE.Color(0);
 
         // activate in the browser with:
         // window.__debugContext.setValue("DEBUG_TEXT_PATHS", true)

@here/harp-omv-datasource/lib/OmvDecoder.ts

@@ -182,7 +182,7 @@ export class OmvDecoder implements IGeometryProcessor {
         private readonly m_projection: Projection,
         private readonly m_styleSetEvaluator: StyleSetEvaluator,
         private readonly m_showMissingTechniques: boolean,
-        private readonly m_dataFilter?: OmvFeatureFilter,
+        dataFilter?: OmvFeatureFilter,
         private readonly m_featureModifier?: OmvFeatureModifier,
         private readonly m_gatherFeatureIds = true,
         private readonly m_createTileInfo = false,
@@ -192,8 +192,8 @@ export class OmvDecoder implements IGeometryProcessor {
         private readonly m_languages?: string[]
     ) {
         // Register the default adapters.
-        this.m_dataAdapters.push(new OmvProtobufDataAdapter(this, m_dataFilter, logger));
-        this.m_dataAdapters.push(new VTJsonDataAdapter(this, m_dataFilter, logger));
+        this.m_dataAdapters.push(new OmvProtobufDataAdapter(this, dataFilter, logger));
+        this.m_dataAdapters.push(new VTJsonDataAdapter(this, dataFilter, logger));
     }
 
     /**

@here/harp-omv-datasource/test/OmvTest.ts

@@ -15,7 +15,6 @@ import {
     OmvFilterString,
     OmvGeometryType
 } from "../index";
-import { com } from "../lib/proto/vector_tile";
 
 import { assert } from "chai";
 

test/ImportTest.ts

@@ -9,7 +9,6 @@ import * as glob from "glob";
 import * as path from "path";
 
 import { assert } from "chai";
-import { stringify } from "querystring";
 
 // tslint:disable:only-arrow-functions
 // tslint:disable:forin

tslint.json

@@ -34,6 +34,7 @@
             }
         ],
         "no-unused-expression": true,
+        "no-unused-variable": true,
         "no-duplicate-variable": true,
         "no-implicit-dependencies": false,
         "no-namespace": false,