This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-9982 Disable line clipping by default #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzjony
previously approved these changes
Apr 16, 2020
ninok
force-pushed
the
minor-disable-clipping
branch
from
dc29abd
to
b67ae58
Compare
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
==========================================
- Coverage 60.60% 60.31% -0.30%
==========================================
Files 278 264 -14
Lines 24530 24258 -272
Branches 5520 5464 -56
==========================================
- Hits 14867 14631 -236
+ Misses 9663 9627 -36
Continue to review full report at Codecov.
|
ninok
force-pushed
the
minor-disable-clipping
branch
from
b67ae58
to
d280758
Compare
nzjony
changed the title
nzjony
reviewed
Apr 21, 2020
@here/harp-mapview/lib/MapView.ts
Outdated
|
|
||
| if (tile.levelOffset >= 0) { | ||
| if (object._backupRenderOrder !== undefined) { | ||
| // We meesed up the render order when this tile was used as fallback. |
There was a problem hiding this comment.
Suggested change
| // We meesed up the render order when this tile was used as fallback. | |
| // We messed up the render order when this tile was used as fallback. |
@here/harp-mapview/lib/MapView.ts
Outdated
|
|
||
| if (tile.levelOffset >= 0) { | ||
| if (object._backupRenderOrder !== undefined) { | ||
| // We meesed up the render order when this tile was used as fallback. |
There was a problem hiding this comment.
Suggested change
| // We meesed up the render order when this tile was used as fallback. | |
| // We messed up the render order when this tile was used as fallback. |
ninok
force-pushed
the
minor-disable-clipping
branch
3 times, most recently
from
4ebfeae
to
41a4a40
Compare
ninok
force-pushed
the
minor-disable-clipping
branch
2 times, most recently
from
ac5a5f8
to
a70df2c
Compare
ninok
force-pushed
the
minor-disable-clipping
branch
from
a70df2c
to
a867cf4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
==========================================
+ Coverage 63.09% 63.16% +0.06%
==========================================
Files 279 279
Lines 25246 25254 +8
Branches 5689 5690 +1
==========================================
+ Hits 15930 15952 +22
+ Misses 9316 9302 -14
Continue to review full report at Codecov.
|
ninok
force-pushed
the
minor-disable-clipping
branch
2 times, most recently
from
213b3bb
to
709c6c5
Compare
ninok
force-pushed
the
minor-disable-clipping
branch
2 times, most recently
from
9dc239e
to
0594929
Compare
nzjony
previously approved these changes
Jun 25, 2020
ninok
force-pushed
the
minor-disable-clipping
branch
from
0594929
to
5c9c5e0
Compare
nzjony
previously approved these changes
Jun 25, 2020
ninok
force-pushed
the
minor-disable-clipping
branch
from
5c9c5e0
to
fbceb32
Compare
nzjony
previously approved these changes
Jul 14, 2020
ninok
force-pushed
the
minor-disable-clipping
branch
from
a1260a6
to
a89a5d1
Compare
ninok
force-pushed
the
minor-disable-clipping
branch
from
a89a5d1
to
e7531b8
Compare
nzjony
approved these changes
Jul 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to disable line clipping since HERE Vector Tiles will soon have a smaller margin.