Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Tile upload throttling HARP-10363 #1597

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

FraukeF
Copy link
Contributor

@FraukeF FraukeF commented Jun 10, 2020

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch 2 times, most recently from cfcb621 to cf61cb6 Compare June 11, 2020 07:09
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #1597 into master will increase coverage by 0.21%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
+ Coverage   62.57%   62.79%   +0.21%     
==========================================
  Files         276      276              
  Lines       24959    24977      +18     
  Branches     5634     5641       +7     
==========================================
+ Hits        15619    15684      +65     
+ Misses       9340     9293      -47     
Impacted Files Coverage Δ
@here/harp-mapview/lib/MapView.ts 65.98% <ø> (+1.33%) ⬆️
@here/harp-mapview/lib/VisibleTileSet.ts 77.04% <56.52%> (+0.21%) ⬆️
@here/harp-mapview/lib/Tile.ts 85.57% <100.00%> (+0.04%) ⬆️
...here/harp-mapview/lib/text/TextElementsRenderer.ts 69.56% <0.00%> (+1.08%) ⬆️
...ere/harp-mapview/lib/composing/LowResRenderPass.ts 44.23% <0.00%> (+3.84%) ⬆️
@here/harp-mapview/lib/CameraMovementDetector.ts 90.14% <0.00%> (+28.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc4169...2608ac8. Read the comment docs.

@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch 5 times, most recently from 439088d to bab3a2b Compare June 15, 2020 07:44
@FraukeF FraukeF changed the title WIP: Tile upload throttling HARP-10363 Tile upload throttling HARP-10363 Jun 15, 2020
@FraukeF FraukeF requested a review from ninok June 15, 2020 07:50
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch from bab3a2b to 7b1c8e6 Compare June 15, 2020 08:53
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch 3 times, most recently from af6b561 to ee91faa Compare June 24, 2020 09:00
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch from ee91faa to 7fb6143 Compare June 25, 2020 11:12
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch from 7fb6143 to 9a09bf1 Compare June 25, 2020 11:20
ninok
ninok previously approved these changes Jun 25, 2020
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch 2 times, most recently from c7979ec to 0f1e1af Compare June 25, 2020 13:06
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch from 0f1e1af to 71d5568 Compare June 25, 2020 13:16
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch from 71d5568 to e9a7774 Compare June 25, 2020 13:44
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
@FraukeF FraukeF force-pushed the upload-throtteling_HARP-10363 branch from e9a7774 to 2608ac8 Compare June 25, 2020 14:27
@FraukeF FraukeF merged commit 0de8865 into master Jun 25, 2020
@FraukeF FraukeF deleted the upload-throtteling_HARP-10363 branch June 25, 2020 14:50
@FraukeF FraukeF restored the upload-throtteling_HARP-10363 branch August 5, 2020 09:23
@musculman musculman deleted the upload-throtteling_HARP-10363 branch October 23, 2020 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants