Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-6703 Fix copying across images #1666

Merged
merged 1 commit into from
Jul 7, 2020
Merged

HARP-6703 Fix copying across images #1666

merged 1 commit into from
Jul 7, 2020

Conversation

nzjony
Copy link
Member

@nzjony nzjony commented Jul 7, 2020

Fix missing function.

@nzjony nzjony requested a review from atomicsulfate July 7, 2020 11:41
atomicsulfate
atomicsulfate previously approved these changes Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1666 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
+ Coverage   62.73%   62.95%   +0.22%     
==========================================
  Files         278      278              
  Lines       25062    25062              
  Branches     5656     5656              
==========================================
+ Hits        15722    15779      +57     
+ Misses       9340     9283      -57     
Impacted Files Coverage Δ
...here/harp-mapview/lib/text/TextElementsRenderer.ts 69.56% <0.00%> (+1.08%) ⬆️
@here/harp-mapview/lib/MapView.ts 65.97% <0.00%> (+1.31%) ⬆️
@here/harp-mapview/lib/VisibleTileSet.ts 79.00% <0.00%> (+1.65%) ⬆️
...ere/harp-mapview/lib/composing/LowResRenderPass.ts 44.23% <0.00%> (+3.84%) ⬆️
@here/harp-mapview/lib/CameraMovementDetector.ts 90.14% <0.00%> (+28.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8af7c...dc766f2. Read the comment docs.

Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
@nzjony
Copy link
Member Author

nzjony commented Jul 7, 2020

@harpgl-bot retest this please

@atomicsulfate atomicsulfate self-requested a review July 7, 2020 12:59
@nzjony nzjony merged commit 692bf14 into master Jul 7, 2020
@nzjony nzjony deleted the HARP-6703_fix branch July 7, 2020 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants