Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: Look-at zoomLevel/distance applies together with bounds #1681

Merged
merged 3 commits into from
Jul 14, 2020

Conversation

germanz
Copy link
Contributor

@germanz germanz commented Jul 13, 2020

zoomLevel/distance are now taken into account when setting via MapView constructor or lookAt method.

German Zargaryan added 2 commits July 13, 2020 14:54
Signed-off-by: German Zargaryan <german.zargaryan@here.com>
@germanz germanz requested a review from ninok July 13, 2020 13:20
Signed-off-by: German Zargaryan <german.zargaryan@here.com>
@germanz germanz force-pushed the lookat-bounds-with-distance branch from 5f7df89 to 2eb3d57 Compare July 13, 2020 13:42
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #1681 into master will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
+ Coverage   62.83%   63.27%   +0.44%     
==========================================
  Files         278      278              
  Lines       25147    25149       +2     
  Branches     5671     5672       +1     
==========================================
+ Hits        15800    15913     +113     
+ Misses       9347     9236     -111     
Impacted Files Coverage Δ
@here/harp-mapview/lib/MapView.ts 67.31% <100.00%> (+2.25%) ⬆️
@here/harp-mapview/lib/VisibleTileSet.ts 77.35% <0.00%> (-1.66%) ⬇️
@here/harp-mapview/lib/Tile.ts 85.71% <0.00%> (+0.63%) ⬆️
...here/harp-mapview/lib/text/TextElementsRenderer.ts 69.56% <0.00%> (+1.08%) ⬆️
...ere/harp-mapview/lib/composing/LowResRenderPass.ts 44.23% <0.00%> (+3.84%) ⬆️
@here/harp-mapview/lib/Utils.ts 77.67% <0.00%> (+8.01%) ⬆️
@here/harp-utils/lib/Logger/ConsoleChannel.ts 84.61% <0.00%> (+15.38%) ⬆️
@here/harp-mapview/lib/CameraMovementDetector.ts 90.14% <0.00%> (+28.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23db76...2eb3d57. Read the comment docs.

@germanz germanz merged commit fbe8dcf into master Jul 14, 2020
@germanz germanz deleted the lookat-bounds-with-distance branch July 14, 2020 06:08
ninok pushed a commit that referenced this pull request Jul 20, 2020
MINOR: Look-at zoomLevel / distance applies together with bounds

Signed-off-by: German Zargaryan <german.zargaryan@here.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants