Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-11235: Add information about deprecation to CodingStyle.md #1690

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

ninok
Copy link
Contributor

@ninok ninok commented Jul 16, 2020

No description provided.

nzjony
nzjony previously approved these changes Jul 16, 2020
CODINGSTYLE.md Outdated
@@ -224,7 +224,7 @@ The purpose of a commit message is to summarize the scope and context of a patch

## Documentation

1. Write your comments in a `typedoc` compliant way.
1. Write your comments in a [TSDoc](https://github.com/Microsoft/tsdoc) compliant way.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, you can specify the actual URL at the end of the page, see: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahm that's pretty cool. Did not know that

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #1690 into master will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
+ Coverage   63.06%   63.37%   +0.30%     
==========================================
  Files         279      279              
  Lines       25222    25222              
  Branches     5685     5685              
==========================================
+ Hits        15907    15984      +77     
+ Misses       9315     9238      -77     
Impacted Files Coverage Δ
@here/harp-mapview/lib/VisibleTileSet.ts 79.00% <0.00%> (+0.23%) ⬆️
...here/harp-mapview/lib/text/TextElementsRenderer.ts 70.01% <0.00%> (+1.10%) ⬆️
@here/harp-materials/lib/MapMeshMaterials.ts 43.58% <0.00%> (+1.13%) ⬆️
@here/harp-mapview/lib/MapView.ts 67.21% <0.00%> (+1.31%) ⬆️
...ere/harp-mapview/lib/composing/LowResRenderPass.ts 44.23% <0.00%> (+3.84%) ⬆️
@here/harp-mapview/lib/Tile.ts 85.71% <0.00%> (+6.34%) ⬆️
@here/harp-utils/lib/Logger/ConsoleChannel.ts 84.61% <0.00%> (+15.38%) ⬆️
@here/harp-mapview/lib/CameraMovementDetector.ts 90.14% <0.00%> (+28.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0114c81...57508d5. Read the comment docs.

@ninok ninok merged commit 0c59100 into master Jul 16, 2020
@ninok ninok deleted the document-deprecation branch July 16, 2020 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants