This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MINOR: Fix race condition with CameraKeyTrackAnimation #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing look-at from within onFinish handler was not applied due to race condition with already stopped animation Signed-off-by: German Zargaryan <german.zargaryan@here.com>
germanz
force-pushed
the
camera-animation-race-fix
branch
from
78324fc
to
722f228
Compare
ninok
approved these changes
Jul 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #1733 +/- ##
==========================================
- Coverage 64.18% 64.15% -0.04%
==========================================
Files 279 279
Lines 25328 25329 +1
Branches 5719 5720 +1
==========================================
- Hits 16256 16249 -7
- Misses 9072 9080 +8
Continue to review full report at Codecov.
|
|
@harpgl-bot retest this please |
1 similar comment
|
@harpgl-bot retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing look-at from within
onFinishhandler was not applied due to race condition with already stopped animation.