This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MINOR: tileWrappingEnabled fixes #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nzjony
commented
Aug 13, 2020
nzjony
commented
- Added test
- Log warning when set and projection is spherical
- Added test - Log warning when set and projection is spherical
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
==========================================
+ Coverage 64.32% 64.34% +0.01%
==========================================
Files 283 283
Lines 25548 25551 +3
Branches 5750 5751 +1
==========================================
+ Hits 16435 16442 +7
+ Misses 9113 9109 -4
Continue to review full report at Codecov.
|
FraukeF
reviewed
Aug 14, 2020
| @@ -1262,6 +1262,10 @@ export class MapView extends EventDispatcher { | |||
| } | |||
|
|
|||
| set tileWrappingEnabled(enabled: boolean) { | |||
| if (this.projection.type === ProjectionType.Spherical) { | |||
| logger.warn("Setting this with spherical projection has no affect. Was this intended?"); | |||
There was a problem hiding this comment.
The more I stumble over the tileWrapping, the more I think it should actually be part of the projection and not of MapView.
This probably goes beyond this fix, but we should at least consider moving it to the projection and see if this would not resolve a lot of this additional and somehow weird and repetitive checks
FraukeF
approved these changes
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.