Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-11152: Fix extruded polygon outlines when style has no minZoomLe… #1768

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

atomicsulfate
Copy link
Collaborator

…vel.

Extrusion animation is enabled by default, when a extruded polygon style
does not define a value "animateExtrusion" value. In this case, if no
minZoomLevel is specified, extrusion does not start until zoom level 16
by default, and therefore outlines are not rendered.

To fix it, extrusion animation is disabled if neither "animateExtrusion"
nor "minZoomLevel" are defined in the style.

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

…vel.

Extrusion animation is enabled by default, when a extruded polygon style
does not define a value "animateExtrusion" value. In this case, if no
minZoomLevel is specified, extrusion does not start until zoom level 16
by default, and therefore outlines are not rendered.

To fix it, extrusion animation is disabled if neither "animateExtrusion"
nor "minZoomLevel" are defined in the style.
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1768 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
+ Coverage   64.32%   64.35%   +0.02%     
==========================================
  Files         283      283              
  Lines       25548    25552       +4     
  Branches     5750     5752       +2     
==========================================
+ Hits        16435    16444       +9     
+ Misses       9113     9108       -5     
Impacted Files Coverage Δ
@here/harp-mapview/lib/AnimatedExtrusionHandler.ts 100.00% <100.00%> (+0.83%) ⬆️
@here/harp-utils/lib/TaskQueue.ts 83.60% <0.00%> (ø)
...rp-webtile-datasource/lib/HereWebTileDataSource.ts 54.36% <0.00%> (ø)
@here/harp-mapview/lib/MapView.ts 66.62% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4316d...0739b56. Read the comment docs.

@atomicsulfate atomicsulfate merged commit 47d91de into master Aug 14, 2020
@atomicsulfate atomicsulfate deleted the HARP-11152_FixExtrudedPolygonOutlines branch August 14, 2020 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants