This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-12728: Add support for webpack5 #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzjony
force-pushed
the
HARP-12623
branch
5 times, most recently
from
f47d7b0
to
207e6c9
Compare
nzjony
changed the title
|
Converting to draft because there are still CI issues that need to be resolved before this can be submitted. |
nzjony
force-pushed
the
HARP-12623
branch
2 times, most recently
from
e2e2e2a
to
824d738
Compare
nzjony
force-pushed
the
HARP-12623
branch
7 times, most recently
from
9d3429d
to
2a4579f
Compare
atomicsulfate
force-pushed
the
HARP-12623
branch
3 times, most recently
from
27f9a20
to
12319a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1917 +/- ##
==========================================
+ Coverage 66.14% 66.22% +0.08%
==========================================
Files 294 294
Lines 26299 26299
Branches 5909 5909
==========================================
+ Hits 17395 17417 +22
+ Misses 8904 8882 -22
Continue to review full report at Codecov.
|
atomicsulfate
force-pushed
the
HARP-12623
branch
from
12319a3
to
7398bcc
Compare
atomicsulfate
force-pushed
the
HARP-12623
branch
2 times, most recently
from
5b94cf5
to
29dd5c9
Compare
atomicsulfate
force-pushed
the
HARP-12623
branch
6 times, most recently
from
bc1bc36
to
5ced4e9
Compare
This change updates the webpack configurations to 5.2.0. Signed-off-by: Roberto Raggi <roberto.raggi@here.com> Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
webpack-cli 4.1.0 has some issue with "webpack serve".
Webpack 5 does not include a polyfill for Node.js process. process.env.NODE_ENV and any other environment variables must be define using the EnvironmentPlugin. process.platform is defined using the DefinePlugin.
They were failing in windows due to calls to process.cwd() done by path module's path.relative() function.
atomicsulfate
force-pushed
the
HARP-12623
branch
7 times, most recently
from
6ec8871
to
9bbdf80
Compare
- Workaround webpack 5 bug by prepending "./" to the webpack config file path, see webpack/webpack#11643 - Add webpack cache to travis cached directories.
Move ts typechecking to separate process using ForkTsCheckerWebpackPlugin.
Version 4.3.0 was always adding "auto" path prefix to scripts in generated html files.
atomicsulfate
force-pushed
the
HARP-12623
branch
from
4f356e1
to
2f8609a
Compare
|
looks good to me |
atomicsulfate
approved these changes
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the webpack configurations to 5.2.0.