This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-12581: Move TextElement construction into builders. #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
HARP-12581_Refactoring
branch
2 times, most recently
from
222e25b
to
c776a54
Compare
atomicsulfate
force-pushed
the
HARP-12581_Refactoring
branch
from
c776a54
to
f5630d8
Compare
FraukeF
previously approved these changes
Nov 24, 2020
| import { assert, assertExists, LoggerManager } from "@here/harp-utils"; | ||
| import * as THREE from "three"; | ||
| import { Vector3 } from "three"; |
There was a problem hiding this comment.
THREE is already imported use THREE.Vector3
| @@ -44,6 +39,38 @@ interface ImageTextureDef { | |||
| pixelRatio?: number; | |||
| } | |||
|
|
|||
| function getPoiImageTexture(poiGeometry: PoiGeometry, index: number = 0): string | undefined { | |||
There was a problem hiding this comment.
just another minor, maybe you can drop the Poi in the name as its inside the PoiManager, getImageTexture might be enough... same for the funtions below
atomicsulfate
force-pushed
the
HARP-12581_Refactoring
branch
from
f5630d8
to
7cd844e
Compare
atomicsulfate
force-pushed
the
HARP-12581_Refactoring
branch
from
7cd844e
to
8d35177
Compare
atomicsulfate
force-pushed
the
HARP-12581_Refactoring
branch
from
8d35177
to
6265864
Compare
FraukeF
approved these changes
Nov 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #1988 +/- ##
==========================================
+ Coverage 65.88% 66.20% +0.31%
==========================================
Files 294 295 +1
Lines 26262 26246 -16
Branches 5952 5910 -42
==========================================
+ Hits 17304 17376 +72
+ Misses 8958 8870 -88
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup text element construction code to remove duplication. Preparation to set renderOrder for text elements.