Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Update typescript to 4.1.2 #2026

Merged
merged 11 commits into from
Jan 12, 2021
Merged

Update typescript to 4.1.2 #2026

merged 11 commits into from
Jan 12, 2021

Conversation

AndriiHeonia
Copy link
Contributor

Update typescript to 4.1.2

@AndriiHeonia
Copy link
Contributor Author

@harpgl_bot retest this please

@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #2026 (b2e3ab4) into master (059999b) will increase coverage by 0.04%.
The diff coverage is 89.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
+ Coverage   66.57%   66.62%   +0.04%     
==========================================
  Files         297      297              
  Lines       26340    26337       -3     
  Branches     5944     5945       +1     
==========================================
+ Hits        17537    17546       +9     
+ Misses       8803     8791      -12
Impacted Files Coverage Δ
...apview/lib/copyrights/CopyrightCoverageProvider.ts 86.48% <ø> (ø)
@here/harp-mapview/lib/image/Image.ts 24.44% <0.00%> (ø)
@here/harp-mapview/lib/poi/PoiRenderer.ts 43.22% <0.00%> (ø)
@here/harp-materials/lib/MapMeshMaterials.ts 55.55% <ø> (+0.15%) ⬆️
@here/harp-transfer-manager/src/DeferredPromise.ts 100.00% <ø> (ø)
@here/harp-mapview/lib/MapViewFog.ts 65.07% <70.00%> (+1.58%) ⬆️
...re/harp-mapview/lib/geometry/overlayOnElevation.ts 86.00% <80.00%> (+3.64%) ⬆️
@here/harp-materials/lib/SolidLineMaterial.ts 57.48% <81.81%> (-2.16%) ⬇️
@here/harp-materials/lib/RawShaderMaterial.ts 96.55% <90.90%> (-3.45%) ⬇️
@here/harp-mapview/lib/DecodedTileHelpers.ts 56.85% <100.00%> (+0.25%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059999b...b2e3ab4. Read the comment docs.

@AndriiHeonia AndriiHeonia force-pushed the HARP-13368 branch 2 times, most recently from bde5d44 to 1697c39 Compare January 6, 2021 10:46
@AndriiHeonia AndriiHeonia marked this pull request as ready for review January 6, 2021 11:04
@atomicsulfate atomicsulfate self-requested a review January 6, 2021 11:54
atomicsulfate
atomicsulfate suggested changes Jan 6, 2021
View reviewed changes
@here/harp-mapview/lib/poi/PoiRenderer.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/MapViewFog.ts Outdated Show resolved Hide resolved
@here/harp-materials/lib/SolidLineMaterial.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/DecodedTileHelpers.ts Outdated Show resolved Hide resolved
@here/harp-materials/lib/CirclePointsMaterial.ts Outdated Show resolved Hide resolved
@here/harp-materials/lib/SolidLineMaterial.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/MapMaterialAdapter.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/geometry/overlayOnElevation.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/geometry/overlayOnElevation.ts Outdated Show resolved Hide resolved
@AndriiHeonia AndriiHeonia force-pushed the HARP-13368 branch 3 times, most recently from b5b759c to 77a1c96 Compare January 11, 2021 09:16
ThFischer and others added 9 commits January 11, 2021 11:48
@ThFischer @AndriiHeonia
HARP-13368: update TypeScript to 4.1.2
f45b496 
TypeScript 4.1.2 required the following adjustments:
- fix harp-examples errors
- remove setter and getter for the "fog" property
- remove setter and getter for the "opacity" property
- remove setter and getter for the "displacementMap" property in MapMeshStandardMaterial

Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
@AndriiHeonia
move code that sets displacementMap to a separate function
f7da678 
Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
@AndriiHeonia
fix eslint error
58e4dc5 
Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
@ThFischer @AndriiHeonia
HARP-13368: moving setOpacity() to RawShaderMaterial
b458413 
Signed-off-by: Fischer, Thomas <Fischer.Th@gmail.com>
@ThFischer @AndriiHeonia
HARP-13368: Fix CirclePointsMaterialParameters
5b23526 
Signed-off-by: Fischer, Thomas <Fischer.Th@gmail.com>
@ThFischer @AndriiHeonia
HARP-13368: Fix CirclePointsMaterialTest
364ccfd 
Signed-off-by: Fischer, Thomas <Fischer.Th@gmail.com>
@ThFischer @AndriiHeonia
HARP-13368: Fix comments
a9e5819 
Signed-off-by: Fischer, Thomas <Fischer.Th@gmail.com>
@AndriiHeonia
fix failing opacity related unit tests
0e77608 
Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
@AndriiHeonia
fix lint errors
7447297 
Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
@AndriiHeonia
add built-in uniforms to CirclePointsMaterial
77194a6 
Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
@AndriiHeonia
fix fog-related errors when circles technique is used
b2e3ab4 
Signed-off-by: Andrii Heonia <andrii.heonia@here.com>
@AndriiHeonia AndriiHeonia merged commit 28e9afd into master Jan 12, 2021
@AndriiHeonia AndriiHeonia deleted the HARP-13368 branch January 12, 2021 10:13
@nzjony nzjony mentioned this pull request Jan 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atomicsulfate atomicsulfate atomicsulfate approved these changes

Assignees
No one assigned
Labels
topic:HARP-13368
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriiHeonia @atomicsulfate @ThFischer