This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-13770: Update the copyright header #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanz
previously approved these changes
Jan 19, 2021
|
@ThFischer , awesome job!! |
germanz
force-pushed
the
HARP-13770
branch
4 times, most recently
from
3eab597
to
78e88b8
Compare
germanz
force-pushed
the
HARP-13770
branch
2 times, most recently
from
5bcf853
to
812e886
Compare
ThFischer
commented
Jan 20, 2021
| * @param callback The callback function to execute upon completion. Array of errors strings is passed back, | ||
| * in case not matching file is found. | ||
| */ | ||
| export function checkLicenses( |
There was a problem hiding this comment.
Parameter fix needs to be documented ("if true, it tries to fix the year(s)")
germanz
force-pushed
the
HARP-13770
branch
2 times, most recently
from
d987caf
to
0c1142d
Compare
|
retest this please |
|
retest this please |
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
=======================================
Coverage 66.64% 66.64%
=======================================
Files 297 297
Lines 26351 26351
Branches 5957 5957
=======================================
Hits 17562 17562
Misses 8789 8789
Continue to review full report at Codecov.
|
Signed-off-by: German Zargaryan <2526045+germanz@users.noreply.github.com>
Signed-off-by: German Zargaryan <2526045+germanz@users.noreply.github.com>
Signed-off-by: German Zargaryan <2526045+germanz@users.noreply.github.com>
Signed-off-by: German Zargaryan <2526045+germanz@users.noreply.github.com>
|
retest this please |
1 similar comment
|
retest this please |
Signed-off-by: German Zargaryan <2526045+germanz@users.noreply.github.com>
germanz
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
test/LicenseHeaderTest.tschecks all files to have correct license header by taking the last and first Git commit of this file into account to check the year statements. It also provides an option to adjust wrong year statements when ran locally (seeAUTO_FIX)