Enable shadows on WebTiles #2125
Conversation
FraukeF
force-pushed
the
webtile-shadows
branch
from
758c16a
to
a39fa28
Compare
Codecov Report
@@ Coverage Diff @@
## master #2125 +/- ##
=======================================
Coverage 67.68% 67.69%
=======================================
Files 298 298
Lines 26384 26389 +5
Branches 5968 5972 +4
=======================================
+ Hits 17858 17864 +6
+ Misses 8526 8525 -1
Continue to review full report at Codecov.
|
FraukeF
force-pushed
the
webtile-shadows
branch
3 times, most recently
from
2befe61
to
5a4c65a
Compare
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
| @@ -61,6 +62,12 @@ function swapCamera() { | |||
| shadowCameraHelper.visible = !shadowCameraHelper.visible; | |||
| } | |||
|
|
|||
| const hereWebTileDataSource = new HereWebTileDataSource({ | |||
There was a problem hiding this comment.
Thanks for expanding the example!
| material, | ||
| true, | ||
| false | ||
| this.dataSource.dataSourceOrder, |
There was a problem hiding this comment.
Hmm, I'm not sure if this is quite correct, because the dataSourceOrder is not the renderOrder, and this value is used internally as the renderOrder.
I think it would make more sense to remove the renderOrder from this function and just set the order to some small value.
There was a problem hiding this comment.
right, the datasourceOrder is evaluated somewhere else. I ll remove it
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -sor append--signoffwhen you are committing to the repo.Happy contributing!