HARP-14495: Updates three to version 0.126.0 #2146
Conversation
germanz
commented
Mar 10, 2021
germanz
commented
- Updates three.js to version 0.126.0
Codecov Report
@@ Coverage Diff @@
## master #2146 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 298 298
Lines 26377 26376 -1
Branches 5970 5970
=======================================
Hits 17858 17858
+ Misses 8519 8518 -1
Continue to review full report at Codecov.
|
| @@ -157,7 +156,9 @@ export class TileObjectRenderer { | |||
| return stableSort(a, b); | |||
| }; | |||
|
|
|||
| this.m_renderer.setOpaqueSort(painterSortStable); | |||
| // Temporary workaround due to incorrect comparator type definition: | |||
There was a problem hiding this comment.
Please create a bug on https://github.com/three-types/three-ts-types and mention it here.
There was a problem hiding this comment.
| @@ -19,6 +18,17 @@ import { | |||
| InterleavedBufferAttribute | |||
| } from "./DecodedTile"; | |||
|
|
|||
| type TypedArray = | |||
There was a problem hiding this comment.
This is necessary, yes, but we could consider to deprecate this type and instead use ArrayLike, because that is the type in the three-ts-types, see: https://github.com/three-types/three-ts-types/blob/master/types/three/src/core/BufferAttribute.d.ts
There was a problem hiding this comment.
What about ArrayBufferView?
There was a problem hiding this comment.
Internally it uses ArrayLike in the three-ts-types, but I guess that works also.
| @@ -835,10 +835,21 @@ function getBaseColorPropName(technique: Technique): string | undefined { | |||
| return getTechniqueDescriptor(technique)?.attrTransparencyColor; | |||
| } | |||
|
|
|||
| type TypedArray = | |||
There was a problem hiding this comment.
I don't think this is necessary, see below.
Signed-off-by: German Zargaryan <2526045+germanz@users.noreply.github.com>
