This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MAPSJS-2783: Faster creation of keys for techniques with dynamic array buffer properties. #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray buffer properties. Instead of stringifying the array buffers, and id is assigned to them and used as part of the technique key. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
=======================================
Coverage 68.43% 68.44%
=======================================
Files 299 299
Lines 26519 26525 +6
Branches 6008 6009 +1
=======================================
+ Hits 18149 18155 +6
Misses 8370 8370
Continue to review full report at Codecov.
|
nzjony
reviewed
Apr 27, 2021
|
|
||
| const techniquesTileB = (() => { | ||
| const ev = new StyleSetEvaluator({ styleSet: texturedStyle }); | ||
| ev.getMatchingTechniques(new MapEnv({ kind: "park", map: { buffer: buffer2 } })); |
There was a problem hiding this comment.
Please also add a test where the buffer: both point to buffer1 and the length is 1
nzjony
reviewed
Apr 27, 2021
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MASPJS-2783_FixTechniqueKeys2
branch
from
43cb2d4
to
32ec19d
Compare
nzjony
approved these changes
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of stringifying the array buffers, an id is assigned to them
and used as part of the technique key.
Signed-off-by: Andres Mandado andres.mandado-almajano@here.com