This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-14678 Fix tile dependencies not working #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
The tile dependency example wasn't working with two separate data sources because the morton code was stored in a Float32Array, which doesn't have enough precision and caused issues. This change stores the row, column and level separately and then in the decoder, the mortonCode is computed and stored as a `number`, which has more accuracy that a 32 bit float. Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
- Coverage 68.44% 68.44% -0.01%
==========================================
Files 299 299
Lines 26526 26529 +3
Branches 6009 6011 +2
==========================================
+ Hits 18156 18158 +2
- Misses 8370 8371 +1
Continue to review full report at Codecov.
|
nzjony
commented
May 4, 2021
| @@ -962,6 +962,11 @@ export class VisibleTileSet { | |||
| visibleTileKeys.find( | |||
| tileKeyEntry => | |||
| tileKeyEntry.tileKey.mortonCode() === tileKey.mortonCode() | |||
| ) === undefined && | |||
| // Check that we haven't already added this TileKey | |||
| dependentTiles.find( | |||
There was a problem hiding this comment.
Note, this isn't related to the bug, it is just a minor optimization.
FraukeF
approved these changes
May 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HARP-14678 Fix issue with morton codes being stored as 32 bit
The tile dependency example wasn't working with two separate data sources because the morton code was stored in a Float32Array, which doesn't have enough precision and caused issues. This change stores the row, column and level separately and then in the decoder, the mortonCode is computed and stored as a
number, which has more accuracy that a 32 bit float.