-
Notifications
You must be signed in to change notification settings - Fork 197
HARP-15446: Control options are not accessible for screen anchor example #2200
Conversation
…creen anchor example
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
==========================================
+ Coverage 66.62% 66.64% +0.02%
==========================================
Files 312 312
Lines 27748 27748
Branches 6201 6201
==========================================
+ Hits 18486 18492 +6
+ Misses 9262 9256 -6
Continue to review full report at Codecov.
|
<style> | ||
.message { | ||
position: absolute; | ||
float: right; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it really need the float: right
, being already absolutely positioned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you're absolutely right, I fixed it.
<br /> This example shows how MapView.getScreenPosition works for various cases | ||
<br /> the red square is painted on the screen in screen coordinates, whereas the green cube | ||
<br /> lives in the world. | ||
<br /> Use the arrow keys or the gui to change the geoPosition | ||
<br /> Jump to next worlds with "j" and "l" | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove those <br />
elements, add proper punctuation and let the browser flow the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, added paragraphs to separate the two different sections.
Signed-off-by: German Zargaryan <2526045+germanz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed fixes for both HARP-15446 and HARP-15426. Thank you!
This change contains several minor fixes to the marker anchors example: