This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MAPSJS-2660: Disable depth test for IconMaterial. #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depth buffer is not cleared after rendering 3D scene. As a results icons were not passing the depth test in some situations, like in globe with top/down view. Depth test is not needed, labels are always on top of other objects and they don't write on the depth buffer. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Codecov Report
@@ Coverage Diff @@
## master #2268 +/- ##
==========================================
- Coverage 67.87% 67.87% -0.01%
==========================================
Files 313 313
Lines 27665 27665
Branches 6191 6191
==========================================
- Hits 18779 18778 -1
- Misses 8886 8887 +1
Continue to review full report at Codecov.
|
atomicsulfate
force-pushed
the
MAPSJS-2660_FixIconRegression
branch
from
3b9d86d
to
70be1ba
Compare
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MAPSJS-2660_FixIconRegression
branch
2 times, most recently
from
6755ec7
to
cc6277e
Compare
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MAPSJS-2660_FixIconRegression
branch
from
cc6277e
to
3e67849
Compare
nzjony
approved these changes
Aug 6, 2021
LukeParky
pushed a commit
to LukeParky/harp.gl
that referenced
this pull request
Aug 8, 2021
* MAPSJS-2660: Disable depth test for IconMaterial. Depth buffer is not cleared after rendering 3D scene. As a results icons were not passing the depth test in some situations, like in globe with top/down view. Depth test is not needed, labels are always on top of other objects and they don't write on the depth buffer. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com> * MAPSJS-2660: Move marker IBCT tests to ScreenSpaceRenderingTests. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com> * MAPSJS-2660: Add IBCT test for marker on zoomed out globe. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth buffer is not cleared after rendering 3D scene. As a result,
icons were not passing the depth test in some situations, like in
globe with top/down view.
Depth test is not needed, labels are always on top of other objects
and they don't write on the depth buffer.
Signed-off-by: Andres Mandado andres.mandado-almajano@here.com