Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MAPSJS-2660: Clean MapViewUtils namespace #2302

Merged
merged 5 commits into from
Sep 3, 2021

Conversation

atomicsulfate
Copy link
Collaborator

Remove from MapViewUtils functions that are unrelated to MapView.
MapViewUtils namespace has now only functions related to view transformations, camera setup, and view bounds computation.

@atomicsulfate atomicsulfate force-pushed the MAPSJS-2660_CleanMapViewUtils branch 3 times, most recently from cf9ee56 to 9045545 Compare August 31, 2021 10:28
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #2302 (5e1a5fc) into master (5616f35) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
+ Coverage   68.29%   68.30%   +0.01%     
==========================================
  Files         317      319       +2     
  Lines       27795    27809      +14     
  Branches     6230     6233       +3     
==========================================
+ Hits        18982    18995      +13     
- Misses       8813     8814       +1     
Impacted Files Coverage Δ
@here/harp-utils/lib/DOMUtils.ts 16.66% <16.66%> (ø)
@here/harp-mapview/lib/geometry/Object3DUtils.ts 69.34% <69.34%> (ø)
@here/harp-geoutils/lib/tiling/TileKeyUtils.ts 92.13% <100.00%> (+5.86%) ⬆️
@here/harp-mapview/lib/FrustumIntersection.ts 97.43% <100.00%> (ø)
@here/harp-mapview/lib/Tile.ts 82.94% <100.00%> (ø)
@here/harp-mapview/lib/Utils.ts 83.39% <100.00%> (+3.31%) ⬆️
@here/harp-mapview/lib/VisibleTileSet.ts 79.77% <100.00%> (-0.05%) ⬇️
@here/harp-mapview/lib/MapMaterialAdapter.ts 92.14% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5616f35...5e1a5fc. Read the comment docs.

0x4000000000000,
0x8000000000000,
0x10000000000000
];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More efficient:
let val = .5;
export const powerOfTwo = Array(53).fill(0).map(() => val *= 2);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Also, move old test to the right place.

Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
@atomicsulfate atomicsulfate merged commit 4432ea4 into master Sep 3, 2021
@atomicsulfate atomicsulfate deleted the MAPSJS-2660_CleanMapViewUtils branch September 3, 2021 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants