Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MAPSJS-2660: Remove camera code from MapView, simplify CameraUtils. #2305

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

atomicsulfate
Copy link
Collaborator

No description provided.

ThFischer
ThFischer previously approved these changes Sep 2, 2021
CameraUtils API.

Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #2305 (a5e7786) into master (5616f35) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
- Coverage   68.29%   68.28%   -0.01%     
==========================================
  Files         317      317              
  Lines       27795    27801       +6     
  Branches     6230     6234       +4     
==========================================
+ Hits        18982    18985       +3     
- Misses       8813     8816       +3     
Impacted Files Coverage Δ
@here/harp-mapview/lib/Utils.ts 79.85% <0.00%> (-0.23%) ⬇️
@here/harp-mapview/lib/CameraUtils.ts 96.77% <96.29%> (-0.98%) ⬇️
@here/harp-mapview/lib/MapView.ts 73.25% <100.00%> (+0.08%) ⬆️
@here/harp-mapview/lib/MapMaterialAdapter.ts 92.14% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5616f35...a5e7786. Read the comment docs.

@atomicsulfate atomicsulfate merged commit 6935082 into master Sep 3, 2021
@atomicsulfate atomicsulfate deleted the MAPSJS-2660_CleanMapView branch September 3, 2021 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants