This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-17373: Fix shader compilation in Safari 15 on MacOS Monterrey. #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
HARP-17373
branch
2 times, most recently
from
f392610
to
19fe4f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2337 +/- ##
==========================================
- Coverage 68.39% 68.37% -0.03%
==========================================
Files 319 319
Lines 27915 27915
Branches 6250 6250
==========================================
- Hits 19093 19086 -7
- Misses 8822 8829 +7
Continue to review full report at Codecov.
|
…onterrey. Shader compilation errors were caused by the uniform names 'diffuse' and 'bitangent'. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
HARP-17373
branch
from
19fe4f9
to
e852e5a
Compare
AndriiHeonia
approved these changes
Nov 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shader compilation errors using Metal through ANGLE compatibility layer were caused by the uniform names 'diffuse' and 'bitangent'.
Signed-off-by: Andres Mandado andres.mandado-almajano@here.com