Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for spatial search optimization #44

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Conversation

omanges
Copy link
Contributor

@omanges omanges commented Aug 17, 2020

Signed-off-by: Omkar Mestry omkar.mestry@here.com

@omanges omanges requested a review from sackh August 17, 2020 10:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #44 into master will decrease coverage by 0.23%.
The diff coverage is 94.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   98.19%   97.96%   -0.24%     
==========================================
  Files          10       10              
  Lines         721      786      +65     
==========================================
+ Hits          708      770      +62     
- Misses         13       16       +3     
Impacted Files Coverage Δ
xyzspaces/utils.py 93.54% <92.59%> (+0.36%) ⬆️
xyzspaces/spaces.py 98.62% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58fb410...1576f86. Read the comment docs.

tests/space/test_space_objects.py Show resolved Hide resolved
xyzspaces/spaces.py Show resolved Hide resolved
xyzspaces/utils.py Outdated Show resolved Hide resolved
xyzspaces/utils.py Outdated Show resolved Hide resolved
xyzspaces/utils.py Outdated Show resolved Hide resolved
xyzspaces/utils.py Outdated Show resolved Hide resolved
xyzspaces/utils.py Show resolved Hide resolved
@omanges omanges force-pushed the spatial_optimise branch 2 times, most recently from bc5720f to 3b79e99 Compare August 17, 2020 11:18
@omanges omanges requested a review from sackh August 17, 2020 11:20
xyzspaces/spaces.py Show resolved Hide resolved
@omanges omanges force-pushed the spatial_optimise branch 2 times, most recently from 3910eb6 to bc7de59 Compare August 17, 2020 11:33
@omanges omanges requested a review from sackh August 17, 2020 11:36
requirements.txt Outdated Show resolved Hide resolved
Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
@omanges omanges force-pushed the spatial_optimise branch 3 times, most recently from 873e2dc to a6909f4 Compare August 17, 2020 18:18
…into spatial_optimise

� Conflicts:
�	tests/space/test_space_objects.py

Signed-off-by: Omkar Mestry <omkar.mestry@here.com>
@omanges omanges merged commit 9419295 into master Aug 18, 2020
@omanges omanges deleted the spatial_optimise branch August 19, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants