Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.d.ts: MatchInitFunction params wrong type + documentation update required #145

Closed
InconstantUA opened this issue Apr 10, 2024 · 2 comments · Fixed by #147
Closed
Assignees

Comments

@InconstantUA
Copy link

In index.d.ts, MatchInitFunction, params has wrong type:
current: params: {[key: string]: string})
should be: params: {[key: string]: any})
because it is not string, it returns an object. Maybe you forgot to align it.

Also, please update documentation:
https://heroiclabs.com/docs/nakama/server-framework/typescript-runtime/function-reference/match-handler/

By the way, in Go documentation it is set correctly:
params map[string]interface{}

Thanks in advance!

@novabyte
Copy link
Member

Thanks for the report @InconstantUA. We can make the change unless you're happy to open a pull request?

@InconstantUA
Copy link
Author

I'm not good at it, still learning. Please do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants