Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byte-unit dependency in commons public interface #282

Open
schneems opened this issue May 9, 2024 · 0 comments
Open

Remove byte-unit dependency in commons public interface #282

schneems opened this issue May 9, 2024 · 0 comments

Comments

@schneems
Copy link
Contributor

schneems commented May 9, 2024

We cannot upgrade this dependency until errors are fixed #252. We should remove it from the interface entirely.

I'm not 100% sure how to gently do this. In ruby I would accept two different input types for awhile and at runtime issue a deprecation warning. I guess in Rust I just remove/change the type and let the compiler fail, maybe rev a breaking change version on commons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant