Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): update boolean logic and add package parser util #2449

Merged
merged 4 commits into from
Aug 17, 2023
Merged

fix(cli): update boolean logic and add package parser util #2449

merged 4 commits into from
Aug 17, 2023

Conversation

zwhitfield3
Copy link
Contributor

This PR fixes a bug caught in our telemetry testing that didn't capture all version and help cli inputs. A package parser util has also been added as similar logic exists in our version function inside our oclif init lifecycle hook.

@zwhitfield3 zwhitfield3 requested a review from a team as a code owner August 17, 2023 21:49
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 21:51 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 21:51 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 21:52 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 21:52 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 21:53 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 21:53 — with GitHub Actions Inactive
@zwhitfield3 @ryandagg
Update packages/cli/src/lib/utils/packageParser.ts
062c499 
Co-authored-by: RyanDagg <ryandagg@users.noreply.github.com>
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:15 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:15 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:15 — with GitHub Actions Inactive
@zwhitfield3 @ryandagg
Update packages/cli/src/lib/utils/packageParser.ts
9515527 
Co-authored-by: RyanDagg <ryandagg@users.noreply.github.com>
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:15 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:15 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:15 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:21 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:21 — with GitHub Actions Inactive
@zwhitfield3 zwhitfield3 temporarily deployed to AcceptanceTests August 17, 2023 22:21 — with GitHub Actions Inactive
ryandagg
ryandagg approved these changes Aug 17, 2023
View reviewed changes
packages/cli/src/global_telemetry.ts Outdated Show resolved Hide resolved
packages/cli/src/hooks/init/version.ts Outdated Show resolved Hide resolved
@zwhitfield3 zwhitfield3 merged commit 9c7099c into main Aug 17, 2023
7 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/telemetry-fix branch August 17, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandagg ryandagg ryandagg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwhitfield3 @ryandagg