WhiteNoise middleware added in the wrong place

[pupeno]

From WhiteNoise's documentation, the middleware should be added after the security one:

Edit your settings.py file and add WhiteNoise to the MIDDLEWARE_CLASSES list, above all other middleware apart from Django’s SecurityMiddleware

http://whitenoise.evans.io/en/stable/#quickstart-for-django-apps

Yet django-heroku adds it before the security middleware.

[ntravis]

Looks pretty straightforward as to why:

django-heroku/django_heroku/core.py

Lines 101 to 105 in 8396b55

	# Insert Whitenoise Middleware.
	try:
	config['MIDDLEWARE_CLASSES'] = tuple(['whitenoise.middleware.WhiteNoiseMiddleware'] + list(config['MIDDLEWARE_CLASSES']))
	except KeyError:
	config['MIDDLEWARE'] = tuple(['whitenoise.middleware.WhiteNoiseMiddleware'] + list(config['MIDDLEWARE']))

For a fix, I've submitted a PR. Not as clean-looking, but does operate within the expected parameters of whitenoise. You could make an assumption about SecurityMiddleware always being first in the list, but that seems fraught. You have to go out to a new variable because list.index modifies the original list, rather than returning the newly modified list, so the original list(config...) won't work since that created an on-the-fly reference.

[superandrew]

+1

[udit-001]

Any updates on this so far? It doesn't seem to work with Django 2.2 😞