Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix casing of cluster constant #181

Merged
merged 2 commits into from
Jan 22, 2018
Merged

fix casing of cluster constant #181

merged 2 commits into from
Jan 22, 2018

Conversation

jdowning
Copy link
Member

Running heroku kafka:wait COLOR -a sushi on my app will not honor the attachment name and instead return data on all addons. This PR fixes the cluster constant so that it does honor that attachment name if provided.

@msakrejda
Copy link
Contributor

Awesome find! Thanks! Looks like Travis is not happy, but I can take a look at that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.704% when pulling 73b43d7 on kafka_wait_bug into bcb58f8 on master.

Copy link
Contributor

@msakrejda msakrejda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Travis. Looks great, thanks.

@msakrejda msakrejda merged commit abceba9 into master Jan 22, 2018
@msakrejda msakrejda deleted the kafka_wait_bug branch January 22, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants