Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Accumulator modulator: goes infinite loop when velocity is zero #96

Open
jkbelcher opened this issue Aug 20, 2023 · 2 comments
Open

Comments

@jkbelcher
Copy link
Collaborator

If the velocity parameter in an Accumulator returns zero, the Accumulator should sit at current value and not increase. Instead it goes infinite loop and freezes the UI.

https://github.com/heronarts/LX/blob/dev/src/main/java/heronarts/lx/modulator/Accumulator.java#L74

@mcslee
Copy link
Member

mcslee commented Aug 21, 2023

Gruesome! 🤮

Thx for catching.

@mcslee
Copy link
Member

mcslee commented Aug 21, 2023

d2d23e1

Not the most elegant fix, could still get stuck but at least won't hang the whole program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants