Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hero Transitions with Custom Segues? #69

Closed
air6199 opened this issue Feb 7, 2017 · 4 comments
Closed

Use Hero Transitions with Custom Segues? #69

air6199 opened this issue Feb 7, 2017 · 4 comments

Comments

@air6199
Copy link

air6199 commented Feb 7, 2017

I'm trying to use a custom segue to slide a view from the bottom of the screen up to around 80 points from the top. This view then has a next button at the bottom, which when pressed will hopefully utilise Hero transitions.

Issue:
I can only get the transitions to work if I use hero_replaceViewController(). However, when i do use this, my view is no longer 80 points from the top but instead it is full screen again. I've tried to transform the view again at various points with no luck.

If i don't use hero_replaceViewController(), then the transitions do not work but the destination view frame is the correct size. I was thinking this may be down to me using custom storyboard segues instead of the standard push, etc?

Any thoughts?

@lkzhao
Copy link
Collaborator

lkzhao commented Feb 7, 2017

If your view is 80 points from the top. Are you displaying the previous VC underneath? If yes, then you are probably using overCurrentContext or overFullScreen modal presentation. Hero doesn't support these two types of modal presentation at the moment. This is something that I would also like to support, but quite hard to implement.

@lkzhao
Copy link
Collaborator

lkzhao commented Feb 7, 2017

A workaround is to add your short VC into your top VC by using addChildViewController and manually add the view in to your topVC's view. Then do a sliding animation. After this, Hero will treat this as a single VC.

@lkzhao
Copy link
Collaborator

lkzhao commented Feb 7, 2017

#37

@lkzhao
Copy link
Collaborator

lkzhao commented Feb 12, 2017

.overFullScreen support is implemented in 0.3.0

@lkzhao lkzhao closed this as completed Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants