Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is windows supported? #24

Closed
precompiler opened this issue Mar 23, 2018 · 3 comments
Closed

Is windows supported? #24

precompiler opened this issue Mar 23, 2018 · 3 comments

Comments

@precompiler
Copy link

precompiler commented Mar 23, 2018

Hi,

I tried to build the project in Windows, but got following error. Does the project support windows?

github.com/JulzDiverse/aviator/vendor/code.cloudfoundry.org/commandrunner/linux_command_runner
..\github.com\JulzDiverse\aviator\vendor\code.cloudfoundry.org\commandrunner\linux_command_runner\linux_command_runner.go:27:11: unknown field 'Setpgid' in struct literal of type syscall.SysProcAttr
..\github.com\JulzDiverse\aviator\vendor\code.cloudfoundry.org\commandrunner\linux_command_runner\linux_command_runner.go:30:18: cmd.SysProcAttr.Setpgid undefined (type *syscall.SysProcAttr has no field or method Setpgid)
..\github.com\JulzDiverse\aviator\vendor\code.cloudfoundry.org\commandrunner\linux_command_runner\linux_command_runner.go:39:11: unknown field 'Setpgid' in struct literal of type syscall.SysProcAttr
..\github.com\JulzDiverse\aviator\vendor\code.cloudfoundry.org\commandrunner\linux_command_runner\linux_command_runner.go:42:18: cmd.SysProcAttr.Setpgid undefined (type *syscall.SysProcAttr has no field or method Setpgid)
..\github.com\JulzDiverse\aviator\vendor\code.cloudfoundry.org\commandrunner\linux_command_runner\linux_command_runner.go:51:11: unknown field 'Setpgid' in struct literal of type syscall.SysProcAttr
..\github.com\JulzDiverse\aviator\vendor\code.cloudfoundry.org\commandrunner\linux_command_runner\linux_command_runner.go:54:18: cmd.SysProcAttr.Setpgid undefined (type *syscall.SysProcAttr has no field or method Setpgid)

@herrjulz
Copy link
Owner

Hi @precompiler,

so unfortunately I never tested aviator on a windows machine before. I don't have a windows machine and also had no need for a windows version yet.

I checked what the issue is and is coming from the command_runner. It is an explicit linux executor, and that is why you got those errors when trying to compile for windows. However, I replaced the code-line with a windows command runner to build the binary and uploaded it: aviator-win You could try this binary, but i cannot guarantee that it is working.

@precompiler
Copy link
Author

Thanks very much for your help @JulzDiverse. I did some test, it works well so far.

@herrjulz
Copy link
Owner

@precompiler thx for opening this issue and giving me feedback. I'll will always add an windows binary of aviator in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants