Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSIB encoding errors with vector index registers 16-31 #68

Closed
petercaday opened this issue Aug 23, 2018 · 4 comments
Closed

VSIB encoding errors with vector index registers 16-31 #68

petercaday opened this issue Aug 23, 2018 · 4 comments

Comments

@petercaday
Copy link

Hi!
First, thanks for all the work making xbyak, it's a great library to work with. I noticed an encoding bug in AVX-512 gather/scatter instructions when the vector index register is in the high half, one of [x,y,z]mm16-31. For instance,
vgatherdps zmm0{k1}, [rax + ymm18]
would be encoded as
vgatherdps zmm0{k1}, [rax + ymm2].
The problem is that the EVEX.V' bit is not set properly in these situations (it is always 1). I have a patch that appears to fix the issue, but I'm not an expert in xbyak's internals, so it might not be the right approach.

Thanks,
Peter

@petercaday
Copy link
Author

Patch attached.
vsib.patch.txt

@herumi
Copy link
Owner

herumi commented Aug 23, 2018

Thank you for the important information. I'll fix it.

@herumi
Copy link
Owner

herumi commented Aug 23, 2018

I fixed it. Thank you again.

@petercaday
Copy link
Author

Thanks for the quick response, and thanks again for your work on xbyak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants