Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency and accessibility of metanode colors #18

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Improve consistency and accessibility of metanode colors #18

merged 2 commits into from
Apr 17, 2019

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Apr 17, 2019

old:
old
new:
new
@dhimmel

@dhimmel
Copy link
Member

dhimmel commented Apr 17, 2019

The side-by-side comparison is nice.

A few things we might also want to include in this PR:

  • git mv hetnet/neo4j/docker/guides/graphstyle.grass hetnet/neo4j/docker/guides/graphstyle-legacy.grass
  • update graphstyle.grass with the new colors

Then following this PR we probably want to update the two metagraph visualizations here. I made these with the macOS OmniGraffle program. Perhaps I could dust off the old machine to update them.

@vincerubinetti
Copy link
Collaborator Author

image

Copy link
Member

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. @vincerubinetti let me know when you are done making changes.

text-color-external: #424242;
text-color-internal: #fafafa;
font-size: 8px;
caption: '{name}';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool, yes must have been an oversight not to put this here.

@vincerubinetti
Copy link
Collaborator Author

Done 👍 ready to merge

@dhimmel dhimmel merged commit 6e08d30 into hetio:master Apr 17, 2019
@vincerubinetti vincerubinetti deleted the better-colors branch April 17, 2019 18:24
@dhimmel
Copy link
Member

dhimmel commented Mar 3, 2023

We were asked by a reviewer about the whether the Hetionet color palettes are color blind friendly, so I made the following figure using http://hclwizard.org:3000/cvdemulator/:

hetionet-metagraph-colorblindness-simulator

It's interesting to see how the colors appear based on different color vision deficiencies. Many of the colors are still differentiable. Also we often show the metanode name or abbreviation along with the colors, such that I don't think any action is needed, just something to consider.

@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Mar 3, 2023

I don't proclaim to be an expert in accessibility or color theory, but I think the best way to make something "color blind friendly" is to make it not rely on colors at all, as you said. Then colors can just be a bonus. I think there's only so much you can do when certain color blindnesses limit you to only ~3 hues, and we have 8 types here. A true expert in color accessibility could probably tweak the brightnesses and saturations and such to be slightly more differentiable, but probably not worthwhile enough to change all the code and figures. I believe I made sure to have text or initials everywhere we used these colors on the website and in connectivity search.

dhimmel added a commit to dhimmel/connectivity-search-manuscript that referenced this pull request Mar 3, 2023
dhimmel added a commit to dhimmel/connectivity-search-manuscript that referenced this pull request Mar 3, 2023
@dhimmel
Copy link
Member

dhimmel commented Mar 3, 2023

I believe I made sure to have text or initials everywhere we used these colors on the website and in connectivity search.

Yes. The visualizations would work without color at all, but would be less pretty.

Looking at the commits in this PR, I see 7417ce9 with message, "improve consistency and accessibility of metanode colors", so I'm inclined to think that accessibility was a criteria for your revisions.

dhimmel added a commit to greenelab/connectivity-search-manuscript that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants