Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primary-ip list can't select ip column #591

Closed
deliciouslytyped opened this issue Oct 30, 2023 · 1 comment · Fixed by #594 or #583
Closed

primary-ip list can't select ip column #591

deliciouslytyped opened this issue Oct 30, 2023 · 1 comment · Fixed by #594 or #583
Assignees
@phm07
Labels
bug

Comments

@deliciouslytyped
Copy link

I may be missing something, but the primary-ip list subcommand does not appear to have an ip column to output when using -o columns=...

$ hcloud primary-ip list --help
Displays a list of Primary IPs.                      
                                                           
Output can be controlled with the -o flag. Use -o noheader to suppress the
table header. Displayed columns and their order can be set with
-o columns=age,assignee (see available columns below).                                                                                                                                                                                        
                                                                                                                                                                                                                                              
Columns:                                                                                                                                                                                                                                      
 - age                                                                                                                                                                                                                                        
 - assignee                                                                                                                                                                                                                                   
 - assignee_id                                                                                                                                                                                                                                
 - assignee_type                                                                                                                                                                                                                              
 - auto_delete                                                                                                                                                                                                                                
 - blocked                                                                                                                                                                                                                                    
 - created                                                                                                                                                                                                                                    
 - dns                                                                                                                                                                                                                                        
 - id                                                                                                                                                                                                                                         
 - labels                                                                                                              
 - name
 - protection                                                                                                                                                                                                                                 
 - type

Usage:
  hcloud primary-ip list [FlAGS]
@phm07
Copy link
Contributor

phm07 commented Oct 31, 2023

You're right, the IP column is missing. I'll open a PR with a fix.

@phm07 phm07 self-assigned this Oct 31, 2023
@phm07 phm07 added the bug label Oct 31, 2023
phm07 added a commit that referenced this issue Oct 31, 2023
@phm07
fix(primary-ip): list does now allow to output IP column
c0f73db 
Since IP is a *hcloud.PrimaryIP, AddAllowedFields() only adds columns for primitive types and a field function for IP was missing, you were not able to output the IP column using output flags.

Closes #591
@phm07 phm07 mentioned this issue Oct 31, 2023
Merged
phm07 added a commit that referenced this issue Oct 31, 2023
@phm07
fix(primary-ip): list does now allow to output IP column
f438705 
Since IP is a *hcloud.PrimaryIP, AddAllowedFields() only adds columns for primitive types and a field function for IP was missing, you were not able to output the IP column using output flags.

Closes #591
phm07 added a commit that referenced this issue Oct 31, 2023
@phm07
fix(primary-ip): list does now allow to output IP column (#594)
ee8e6ed 
Since IP is a ``*hcloud.PrimaryIP``, ``AddAllowedFields()`` only adds
columns for primitive types and a field function for IP was missing, you
were not able to output the IP column using output flags.

Closes #591
@hcloud-bot hcloud-bot mentioned this issue Oct 31, 2023
Merged
phm07 added a commit that referenced this issue Oct 31, 2023
@phm07
fix(primary-ip): list does now allow to output IP column (#594)
90e7088 
Since IP is a ``*hcloud.PrimaryIP``, ``AddAllowedFields()`` only adds
columns for primitive types and a field function for IP was missing, you
were not able to output the IP column using output flags.

Closes #591
phm07 pushed a commit that referenced this issue Nov 14, 2023
@hcloud-bot
chore(main): release 1.40.0 (#583)
1143e07 
🤖 I have created a release *beep* *boop*
---


##
[1.40.0](v1.39.0...v1.40.0)
(2023-11-14)


### Features

* add warning messages to context commands
([#605](#605))
([d84fe36](d84fe36)),
closes [#588](#588)
* allow JSON output on resource creation
([#609](#609))
([d7241fe](d7241fe)),
closes [#470](#470)
* **context:** ask to use HCLOUD_TOKEN when creating new context
([#582](#582))
([54e582a](54e582a)),
closes [#576](#576)
* pretty-print JSON output
([#610](#610))
([ca4706f](ca4706f))
* print out IPs after they were created
([#590](#590))
([0e0eaa8](0e0eaa8))


### Bug Fixes

* "create" actions were not awaited in some cases
([#589](#589))
([1c0e50a](1c0e50a))
* **image:** backup is suggested as type in update command
([#603](#603))
([6ea4695](6ea4695))
* inconsistent formatting in "describe" commands
([#593](#593))
([b70dfe3](b70dfe3))
* **network:** create prints success to stderr instead of stdout
([#587](#587))
([0a4c361](0a4c361))
* **primary-ip:** list does now allow to output IP column
([#594](#594))
([ee8e6ed](ee8e6ed)),
closes [#591](#591)
* **primary-ip:** updating the name resets auto-delete
([#604](#604))
([292f6c4](292f6c4))
* static resource list commands only return first 50 entries
([#592](#592))
([7e511d9](7e511d9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@Porkepix Porkepix mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phm07 phm07

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@phm07 @deliciouslytyped