Adding firewall rule fails with version v1.43.0

[Dari4sho]

TL;DR

Starting from v1.43.0, adding a firewall rule fails with hcloud: invalid input in field 'rules' (invalid_input)

Expected behavior

Firewall rule being added successfully

Observed behavior

Adding firewall rule fails with hcloud: invalid input in field 'rules' (invalid_input)

Minimal working example

I am running hcloud on a scheduled pipeline always using the latest version.
Since the release of v1.43.0 yesterday, adding a firewall rule fails for me.

This is the command that I run:
hcloud firewall add-rule 1234567 --direction=in --port=2205 --protocol=tcp --source-ips=12.34.56.78/32 --description="Temp access"

It works fine with version v1.42.0.

Log output

`hcloud: invalid input in field 'rules' (invalid_input)`

Additional information

Fails on version v1.43.0
Works on version v1.42.0

[apricote]

Can reproduce, request and response bodies:

--- Request:
POST /v1/firewalls/1254648/actions/set_rules HTTP/1.1
Host: api.hetzner.cloud
User-Agent: hcloud-cli/1.43.0-dev hcloud-go/2.7.0
Content-Length: 499
Authorization: REDACTED
Content-Type: application/json
Accept-Encoding: gzip

{"rules":[{"direction":"in","source_ips":["0.0.0.0/0"],"destination_ips":[],"protocol":"tcp","port":"22","description":null},{"direction":"out","source_ips":[],"destination_ips":["::/0"],"protocol":"tcp","port":"443","description":null},{"direction":"in","source_ips":["2001:db8:123:4567::/64"],"destination_ips":[],"protocol":"tcp","port":"22","description":null},{"direction":"in","source_ips":["12.34.56.78/32"],"destination_ips":null,"protocol":"tcp","port":"2205","description":"Temp access"}]}

--- Response:
HTTP/2.0 422 Unprocessable Entity
Content-Length: 286
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: DNT,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Range,Authorization
Access-Control-Allow-Methods: GET, PUT, POST, DELETE, PATCH, OPTIONS
Access-Control-Allow-Origin: *
Access-Control-Max-Age: 1728000
Content-Type: application/json
Date: Fri, 05 Apr 2024 15:30:39 GMT
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Correlation-Id: 34395fd8f78fd233

{
  "error": {
    "message": "invalid input in field 'rules'",
    "code": "invalid_input",
    "details": {
      "fields": [
        {
          "name": "rules.3.destination_ips",
          "messages": [
            "Field may not be null."
          ]
        }
      ]
    }
  }
}

[phm07]

This was introduced with hetznercloud/hcloud-go#396 and is an unexpected inconsistency with the API. The API does not emit the destination_ips field in responses, but expects it to be omitted in requests. (Same probably goes for description)

[apricote]

Fixed in v1.43.1.

Thanks for the report @Dari4sho!