Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for Robot servers #561

Merged
merged 4 commits into from Nov 21, 2023
Merged

feat: support for Robot servers #561

merged 4 commits into from Nov 21, 2023

Conversation

apricote
Copy link
Member

Based on the Fork by Syself and the Design Doc in #523 (comment).

This ports most of the features the Fork while refactoring them to match our coding style and the improvements I made in preparation for this.

I recommend reviewing by commit.

Docs are still being worked on and will be added in a follow up PR before making a release.

Closes #525 #526 #527

@apricote apricote added the enhancement New feature or request label Nov 13, 2023
@apricote apricote self-assigned this Nov 13, 2023
@apricote apricote requested a review from a team as a code owner November 13, 2023 14:16
apricote
apricote commented Nov 13, 2023
View reviewed changes
hcloud/instances.go Outdated Show resolved Hide resolved
jooola
jooola reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a first pass, I think some small things could be made more consistent.

.golangci.yaml Outdated Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
hack/robot-e2e/ansible.cfg Outdated Show resolved Hide resolved
hack/robot-e2e/ansible.cfg Outdated Show resolved Hide resolved
hack/robot-e2e/e2e-setup-robot-server.yml Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/providerid/providerid.go Outdated Show resolved Hide resolved
internal/robot/client.go Outdated Show resolved Hide resolved
internal/robot/client.go Outdated Show resolved Hide resolved
internal/robot/ratelimit.go Outdated Show resolved Hide resolved
@apricote
Copy link
Member Author

Implemented all review feedback. Diff here: https://github.com/hetznercloud/hcloud-cloud-controller-manager/compare/dee5e961e27d41f309292c45b3c011ef107c8a4b..2af7752e1d6a85a4062584d5e57aedc70cad4f7b

@apricote
Copy link
Member Author

Tests failed before as I forgot to add the ROBOT_ENABLED flag to the helm chart: https://github.com/hetznercloud/hcloud-cloud-controller-manager/compare/2af7752e1d6a85a4062584d5e57aedc70cad4f7b..32491034b7545c00a95ede32b3a9e80a4376edb8

@apricote apricote mentioned this pull request Nov 15, 2023
Closed
jooola
jooola reviewed Nov 15, 2023
View reviewed changes
chart/values.yaml Show resolved Hide resolved
internal/robot/client.go Outdated Show resolved Hide resolved
internal/robot/client.go Outdated Show resolved Hide resolved
tests/e2e/testing.go Outdated Show resolved Hide resolved
jooola
jooola approved these changes Nov 17, 2023
View reviewed changes
hack/dev-up.sh Show resolved Hide resolved
hcloud/instances.go Show resolved Hide resolved
@apricote
Copy link
Member Author

Waiting on #564 for a final rebase & CI fixing run.

@apricote apricote mentioned this pull request Nov 21, 2023
Merged
jooola
jooola reviewed Nov 21, 2023
View reviewed changes
hack/robot-e2e/ansible.cfg Outdated Show resolved Hide resolved
apricote and others added 3 commits November 21, 2023 09:26
@apricote
chore: update dev-env to support Robot servers
dc68024
@apricote
feat(helm): add options for robot
d2d8944
@apricote @janiskemper
@DENKweit @guettli @kranurag7 @batistein
feat: merge syself code for Robot support
b8a519d 
Co-authored-by: janiskemper <janis.kemper@syself.com>
Co-authored-by: Mawe Sprenger <mawe.sprenger@denkweit.de>
Co-authored-by: Thomas Guettler <thomas.guettler@syself.com>
Co-authored-by: Anurag <contact.anurag7@gmail.com>
Co-authored-by: batistein <sven.batista-steinbach@syself.com>
@apricote
test(e2e): add robot server setup
c6ca2ae 
This commit adds setup code to initialize & use Robot servers in e2e
tests.

It uses installimage with autosetup to prepare the server and then uses
k3sup similar to our existing setup to join the server into the
existing kubernetes cluster.

Right now it only supports joining Robot servers as worker nodes, not
for the control-plane.

Also, it only supports non-Private Network setups.
@apricote apricote requested a deployment to e2e-robot November 21, 2023 11:19 — with GitHub Actions Abandoned
@apricote apricote merged commit 65dea11 into main Nov 21, 2023
8 checks passed
@apricote apricote deleted the support-robot-servers branch November 21, 2023 12:08
@apricote apricote mentioned this pull request Nov 21, 2023
Closed
@hcloud-bot hcloud-bot mentioned this pull request Nov 21, 2023
Merged
This was referenced Nov 21, 2023
Closed
Closed
@apricote apricote mentioned this pull request Nov 28, 2023
Merged
apricote added a commit that referenced this pull request Dec 1, 2023
@apricote @jooola
docs: describe new Hetzner Robot integration (#568)
956c2ef 
- Add documentation for the features introduced in #561.
- Cleans up some other documentation fragments that have become outdated
with time.

Closes #528

Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
apricote pushed a commit that referenced this pull request Dec 1, 2023
@hcloud-bot
chore(main): release 1.19.0-rc.0 (#538)
ff24e7b 
🤖 I have created a release *beep* *boop*
---


##
[1.19.0-rc.0](v1.18.0...v1.19.0-rc.0)
(2023-12-01)


### Features

* **chart:** add daemonset and node selector
([#537](#537))
([a94384f](a94384f))
* **config:** stricter validation for settings
`HCLOUD_LOAD_BALANCERS_ENABLED`, `HCLOUD_METRICS_ENABLED` &
`HCLOUD_NETWORK_ROUTES_ENABLED`
([#546](#546))
([335a2c9](335a2c9))
* **helm:** remove "v" prefix from chart version
([#565](#565))
([f11aa0d](f11aa0d)),
closes
[#529](#529)
* **load-balancer:** handle planned targets exceedings max targets
([#570](#570))
([8bb131f](8bb131f))
* remove unused variable NODE_NAME
([#545](#545))
([a659408](a659408))
* **robot:** handle ratelimiting with constant backoff
([#572](#572))
([2ddc201](2ddc201))
* support for Robot servers
([#561](#561))
([65dea11](65dea11))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@apricote apricote mentioned this pull request Dec 7, 2023
Merged
apricote added a commit that referenced this pull request Dec 7, 2023
@apricote
chore(main): release 1.19.0 (#580)
4fc5527 
## [1.19.0](v1.18.0...v1.19.0)
(2023-12-07)


### Features

* **chart:** add daemonset and node selector
([#537](#537))
([a94384f](a94384f))
* **config:** stricter validation for settings
`HCLOUD_LOAD_BALANCERS_ENABLED`, `HCLOUD_METRICS_ENABLED` &
`HCLOUD_NETWORK_ROUTES_ENABLED`
([#546](#546))
([335a2c9](335a2c9))
* **helm:** remove "v" prefix from chart version
([#565](#565))
([f11aa0d](f11aa0d)),
closes
[#529](#529)
* **load-balancer:** handle planned targets exceedings max targets
([#570](#570))
([8bb131f](8bb131f))
* remove unused variable NODE_NAME
([#545](#545))
([a659408](a659408))
* **robot:** handle ratelimiting with constant backoff
([#572](#572))
([2ddc201](2ddc201))
* support for Robot servers
([#561](#561))
([65dea11](65dea11))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooola jooola jooola approved these changes

Assignees

@apricote apricote

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Port & Review Changes from Syself fork
2 participants
@apricote @jooola