feat: build with Go 1.21 #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test was flaky in Go 1.20+ where the seed was randomized on startup. Shuffling the src array would lead to deviations in the result, as the elements from src are added to dst in the order they appear.
jooola
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used Go 1.19 which is EOL.
Also update
golangci-linttov1.54.2and fix issues that showed up:depguardpreviously did not run because we did not provide a configuration. The new version of golangci-lint includes an updated depguard that now defaults to denying all importsstructcheck,deadcode&varcheckare deprecated by their upstreamrand.Seed()is unecessary since Go 1.20