Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently Implemented Search is Deprecated #10

Closed
ckarbass opened this issue Jun 5, 2010 · 6 comments
Closed

Currently Implemented Search is Deprecated #10

ckarbass opened this issue Jun 5, 2010 · 6 comments

Comments

@ckarbass
Copy link

ckarbass commented Jun 5, 2010

The search implemented is deprecated. There is a new "people-search" api:
http://developer.linkedin.com/docs/DOC-1191

@vladgurovich
Copy link

I have a suspicion that this gem may need to be redone from the ground up to support a more flexible search model provided by people/search
The whole idea of field selectors doesn't fit into predefined set of profile attributes provided with this gem.
This is just an educated guess on my part

@joshk
Copy link
Collaborator

joshk commented Mar 1, 2011

Hi ckarbass and vladgurovich,

I am currently updating the gem to work correctly with the xml apis, this includes updating search which is out of date (pull requests are more than welcome as well).

Regarding redoing the gem from the ground up, this is currently going on in another branch (json api, hashie, multi_json, and maybe oauth2), but this will take a little longer than initially planned.

As for the field selectors, this is ingrained in the LinkedIn api, so there is not much I can do about it, but if you have some suggestions I am all ears.

I will leave this issue open until the search api is working as per the updated api.

Thanks,

Josh

@vladgurovich
Copy link

A simpler but slightly less readable approach would be to abandon individual objects such as languages, country, etc etc in favor of something like Hashie(or specifically Mash).
The problem of course is that due to dynamic nature of field selectors, the structure of returned data is not as strict as one provided by your current implementation and will probably require the end users of your gem to have some knowledge of linked in responses.
Oh, I just noticed the mashie branch :)

@joshk
Copy link
Collaborator

joshk commented Mar 1, 2011

Hey vladgurovich,

Once V0.2.0 of the gem is released all my efforts will be focused on the new Hashie (Mash) Json branch, 90% less code with 50% more functionality*.

Watch this space

Josh

*numbers are not quantifiable, but you get the picture :)

@oscardelben
Copy link

Hi, there is a new a pull request for the new search api

@hexgnu
Copy link
Owner

hexgnu commented Apr 27, 2013

Works for me, feel free to reopen this.

@hexgnu hexgnu closed this as completed Apr 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants