Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

При смене email в github на CB создаётся новый юзер. Невозможно войти в старого. #399

Closed
fey opened this issue Aug 3, 2023 · 0 comments
Closed

При смене email в github на CB создаётся новый юзер. Невозможно войти в старого. #399

fey opened this issue Aug 3, 2023 · 0 comments

Comments

@fey
Copy link
Contributor

fey commented Aug 3, 2023 •
edited

Если сменить почту на github то при входе с помощью github на CB будет создан новый юзер.
Так как сопоставление внутри идёт по email

hexlet-basics/app/services/social_network_service.rb

Line 5 in 4e60f49

user = User::SocialSignupForm.find_or_initialize_by(email: auth.info.email.downcase)

Ожидаемое поведение

После смены емейла в гитхабе, пользователь может войти в свой аккаунт на КБ. А емейл пользователя на КБ обновится.
@usernaimandrey usernaimandrey mentioned this issue Aug 28, 2023
Merged
usernaimandrey added a commit that referenced this issue Aug 31, 2023
@usernaimandrey
[#399] take into account the change of email when authenticating thro…
7d7e802 
…ugh github (#403)

* take into account the change of email when authenticating through github

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fey @usernaimandrey