Unsupported browsers #206
Merged
Unsupported browsers #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frontstall
commented
Aug 18, 2021
frontstall
commented
mokevnin
reviewed
Aug 18, 2021
app/helpers/packs_helper.rb
Outdated
| @@ -13,7 +13,9 @@ def prepend_javascript_packs(*packs) | |||
| end | |||
|
|
|||
| def render_javascript_stored_packs | |||
| javascript_pack_tag(*@javascript_packs, crossorigin: 'anonymous') | |||
| if supported_browser? | |||
There was a problem hiding this comment.
Эта логика должна быть снаружи, а не внутри. Уровни абстракции все дела
mokevnin
reviewed
Aug 18, 2021
| @@ -0,0 +1 @@ | |||
| .alert.alert-warning[role="alert"] = t('.error') | |||
There was a problem hiding this comment.
Стандарт именования не тот, это не ошибка, это объяснение. Нужно исходить из того, что ключ на английском без перевода будет смотреться смотрибельно
mokevnin
reviewed
Aug 18, 2021
| @@ -4,6 +4,8 @@ html.x-h-md-100 lang="#{I18n.locale}" | |||
| = render 'layouts/shared/head' | |||
| = Gon::Base.render_data | |||
| body.d-flex.flex-column.x-h-md-100 | |||
| - if !supported_browser? | |||
mokevnin
reviewed
Aug 18, 2021
config/locales/ru.layouts.yml
Outdated
| @@ -26,3 +26,5 @@ ru: | |||
| recommended_books: Рекомендуемые книги | |||
| matrix: Матрица компетентности | |||
| source_code: Исходный код | |||
| unsupported_browser_warning: | |||
| error: Вы используете устаревший браузер. Некоторые возможности отключены. | |||
There was a problem hiding this comment.
Формулировка агрессивная, на людей низя указывать. "Ваш браузер устарел". Нужно всегда уходить от указаний на людей
frontstall
force-pushed
the
unsupported-browsers
branch
from
2c3df6e
to
6c23424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.