Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain should not be uri encoded (for IDN) #63

Closed
tomap opened this issue Aug 18, 2018 · 3 comments · Fixed by hexojs/hexo-generator-sitemap#68
Closed

Domain should not be uri encoded (for IDN) #63

tomap opened this issue Aug 18, 2018 · 3 comments · Fixed by hexojs/hexo-generator-sitemap#68

Comments

@tomap
Copy link
Contributor

tomap commented Aug 18, 2018

Hi,

You should not uri encode the domain. For IDN (international domain names), it produces the wrong result:
https://github.com/hexojs/hexo-generator-feed/blob/master/atom.xml#L8
https://tpî.eu should not be uri encoded into https://tp%C3%AE.eu/
You can either leave is like that or use the punycode version https://xn--tp-rja.eu/ (but I'm not sure you have a function for that and it is not needed)
@tomap
Copy link
Contributor Author

tomap commented Aug 19, 2018

Same for rss2 link and gui tags:
https://github.com/hexojs/hexo-generator-feed/blob/master/rss2.xml#L7

@tomap tomap mentioned this issue Jul 9, 2019
Merged
@curbengh
Copy link
Contributor

#82

@curbengh
Copy link
Contributor

hexo-generator-sitemap might have similar issue.

@curbengh curbengh mentioned this issue Aug 10, 2019
Closed
@curbengh curbengh mentioned this issue Aug 24, 2019
Merged
2 tasks
This was referenced Sep 2, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(idn): encode url except domain curbengh/hexo-generator-sitemap
2 participants
@tomap @curbengh