Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IDN #82

Merged
merged 4 commits into from
Jul 20, 2019
Merged

Support IDN #82

merged 4 commits into from
Jul 20, 2019

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Jul 9, 2019

By not escaping domains with encodeURI (only path)
See #63

tomap added 2 commits July 9, 2019 08:53
@tomap
Support IDN
17cd99a 
By not escaping domains with encodeURI (only path)
@tomap
fix lint
85652d9
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 17cd99a on tomap:master into 0c26cbd on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 17cd99a on tomap:master into 0c26cbd on hexojs:master.

@coveralls
Copy link

coveralls commented Jul 9, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 85652d9 on tomap:master into 0c26cbd on hexojs:master.

curbengh
curbengh approved these changes Jul 20, 2019
View reviewed changes
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested non-ascii domain.

@curbengh curbengh merged commit 613ce87 into hexojs:master Jul 20, 2019
@curbengh curbengh mentioned this pull request Jul 20, 2019
Closed
@curbengh curbengh mentioned this pull request Aug 10, 2019
Closed
@curbengh curbengh mentioned this pull request Aug 24, 2019
Merged
2 tasks
@curbengh curbengh mentioned this pull request Sep 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomap @coveralls @curbengh @yoshinorin