Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(open_graph): add default locale #3924

Merged
merged 1 commit into from
Dec 10, 2019
Merged

test(open_graph): add default locale #3924

merged 1 commit into from
Dec 10, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 10, 2019 •
edited
Loading

What does it do?

Fix (soft) failing test due to incomplete #3921

How to test

git clone -b test-default-locale https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@curbengh curbengh requested a review from a team December 10, 2019 12:20
@curbengh curbengh mentioned this pull request Dec 10, 2019
Merged
2 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.13% when pulling bfafd00 on curbengh:test-default-locale into 140ed36 on hexojs:master.

@curbengh curbengh mentioned this pull request Dec 10, 2019
Merged
2 tasks
@curbengh curbengh added this to the 4.2.1 milestone Dec 10, 2019
@SukkaW SukkaW merged commit c19096b into hexojs:master Dec 10, 2019
@curbengh curbengh deleted the test-default-locale branch December 10, 2019 20:47
@SukkaW SukkaW mentioned this pull request Dec 12, 2019
Merged
1 task
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
test(open_graph): add default locale (hexojs#3924)
fb9cf04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW