Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open_graph): set default locales #3921

Merged
merged 1 commit into from Dec 10, 2019
Merged

Conversation

@curbengh
Copy link
Contributor

curbengh commented Dec 10, 2019

What does it do?

#3808 introduces a 馃悢 馃 issue; setting "language" (like "en") prevent og:locale from being inserted, setting "language-TERRITORY" (like "en-GB") breaks theme's multilingual/i8n support.

This PR fixes that by assuming default locales.
Based on Facebook's official list.

How to test

git clone -b og-locale-backward https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 10, 2019

Coverage Status

Coverage increased (+0.004%) to 97.14% when pulling 9aceb2f on curbengh:og-locale-backward into 979d1f4 on hexojs:master.

@SukkaW
SukkaW approved these changes Dec 10, 2019
@curbengh curbengh merged commit 219fded into hexojs:master Dec 10, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.004%) to 97.14%
Details
@curbengh curbengh deleted the curbengh:og-locale-backward branch Dec 10, 2019
@curbengh curbengh added this to the 4.1.1 milestone Dec 10, 2019
@SukkaW SukkaW mentioned this pull request Dec 12, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.