allow usage together with other golden packages #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other packages can also define an -update flag. In general we can't be compatible with every possible conflicting flag, but for this specific flag we assume that it's a boolean flag with the same meaning as ours. My motivation for this change is usage of autogold along with gotest.tools/v3/assert, which among other things, has its own golden tests functionality.
slimsag
reviewed
Jul 14, 2023
slimsag
approved these changes
Jul 14, 2023
Closed
michaellzc
pushed a commit
to michaellzc/autogold
that referenced
this pull request
Sep 6, 2023
* allow usage together with other golden packages Other packages can also define an -update flag. In general we can't be compatible with every possible conflicting flag, but for this specific flag we assume that it's a boolean flag with the same meaning as ours. My motivation for this change is usage of autogold along with gotest.tools/v3/assert, which among other things, has its own golden tests functionality. --------- Co-authored-by: Stephen Gutekanst <stephen.gutekanst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other packages can also define an -update flag. In general we can't be compatible with every possible conflicting flag, but for this specific flag we assume that it's a boolean flag with the same meaning as ours.
My motivation for this change is usage of autogold along with gotest.tools/v3/assert, which among other things, has its own golden tests functionality.
There's an open PR for
gotest.tools/v3/assertto do the same - see gotestyourself/gotest.tools#271.