ISO3166 namespace similar to ISO4217 used in currencies gem + fixes related to currencies 0.4.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 8, 2011 08:25
As in "currencies" gem prior to 0.3.0 we use namespace ISO4217 to prevent name collisions. This also allow test to pass when using "currencies" in 0.4.0 version.
From now default behavior is to use ISO3166::Country. Country class is still there for backward compatibility. It is inherited from ISO3166::Country. Version bumped to 0.4.0 to match currencies gem with similar functionality.
Also speeds up and give "lazy" usage of "country".
It allow to find by name and name aliases.
|
We add some changes: Clean some code. Add .find_by_name method useful for searching via name aliases. |
|
Code committed and a new gem pushed out. Once again, thank you for your contributions to the project. |
hexorx
pushed a commit
that referenced
this pull request
Mar 27, 2013
Change 'Viet Nam' to 'Vietnam'.
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced ISO3166 namespace for countries gem similar to ISO4217 used in currencies gem.
There is also fix to support currencies 0.4.0 gem in countries properly.
countries gem has version 0.4.0 to match currencies with similar functionalities.