Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Russian Federation instead Russia and fix and add RU.yml subdivisions translation #128

Merged
merged 2 commits into from
Mar 14, 2014

Conversation

mibamur
Copy link
Contributor

@mibamur mibamur commented Mar 9, 2014

  1. Fix Russian Federation in country translation not Russia
  2. Add new one and remove old subdivisions
  3. Add translation for subdivisions like:
YAR:
  name: Yaroslavskaya oblast'
  names:
  - Jaroslavskaja Oblast
  - Jaroslavl
  translations: "Ярославская область"
c = Country['RU']
c.subdivisions.each do |e|
  puts e[1]['translations']
end

@mibamur
Copy link
Contributor Author

mibamur commented Mar 9, 2014

I should write test, but how better do it?
I get last ISO 3166-2 from isoquery:
isoquery --iso 3166-2 | grep RU-

and I have idea add central city in subdivisions like:

YAR:
  name: Yaroslavskaya oblast'
  names:
  - Jaroslavskaja Oblast
  - Jaroslavl
  city: Jaroslavl
  -  "Ярославль"
  translations: "Ярославская область"

@hexorx what do you think about this PR, city idea and simple translation implemintation

If you have plan storing only ISO "data" this PR ISO compabality only + translation

hexorx added a commit that referenced this pull request Mar 14, 2014
Fix Russian Federation instead Russia and fix and add RU.yml subdivisions translation
@hexorx hexorx merged commit 92ae1c9 into countries:master Mar 14, 2014
@hexorx
Copy link
Collaborator

hexorx commented Mar 14, 2014

I like the idea of storing all sorts of country data. Adding the capitol and/or largest city could be useful. If we want to start storing a list of cities as well though it might be best to move some of the data into an outside service.

@mibamur
Copy link
Contributor Author

mibamur commented Mar 16, 2014

yes, city outside only
but each country have own political vision, for example Russia:

Russia:
  West:
    Subdivision: # can be one of 5 type Republic or something else
      Area: # it like area around New Work  - I mean all village near New Work City
        City: # it can be central city, town, village and so own
          Area inside City: # Moscow have more than ten milion citizen, so and can have "village" inside big city
          Zipcode: # and only then we have postcode or zipcode for each Area inside City
            Street: # it is another talks )))
              Building: # house
                Appartment: # room

how it would be better place no ISO data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants