add continents

[lukkry]

I've written tiny script to assign continents. It uses this gem to get continents' names.

I've assigned all countries from Oceania region to Australia continent. It could be great if someone can confirm if it's correct ;)

[hexorx]

You are on the right path but according to (https://github.com/ravibhim/continents/blob/master/lib/ravibhim/data/australia.yml) the only two countries considered part of the "Australia" continent are Australia and New Zealand. Maybe your script could be modified to just open each of the yml files in that gem and build up a list of country codes for each continent. I think some island countries might not be part of a country just like Antarctica is a continent with no countries.

[lukkry]

I've completely changed my approach and rewrited the script. This time I use MaxMind's data to obtain continents' names. I believe this data is reliable.

Any thoughts?

[hexorx]

That data looks good to me.
—
Sent from Mailbox for iPhone

On Sat, Feb 9, 2013 at 4:51 PM, Lukasz Krystkowiak
notifications@github.com wrote:

I've completely changed my approach and rewrited the script. This time I use MaxMind's data to obtain continents' names. I believe this data is reliable.

Any thoughts?

Reply to this email directly or view it on GitHub:
#32 (comment)