Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added and corrected german translations #45

Merged
merged 1 commit into from
Mar 8, 2013
Merged

Conversation

benben
Copy link

@benben benben commented Mar 2, 2013

i added german translations. sometimes i copied only the entries for the german translation to be always on second position.

💖 😺

@hexorx
Copy link
Collaborator

hexorx commented Mar 6, 2013

It looks like the patch added some of the names in twice. Since it is an array it shouldn't cause a problem in most cases but it is redundant.

@benben
Copy link
Author

benben commented Mar 6, 2013

hi,

sure, you are right. there were already some duplicates in it, so i just added some more to put english on first, german on second and french on third. so it is much more easy to grab a language without some crazy logic in your application (check if there are more then one elements in name array, if there are only two, maybe german is the first one in this case, ...).
the cleaner way would be to do something like this, but i think it would break the public "api" of the gem

names:
  en: Italy
  de: Italien
  fr:
  es:

I can do that, if you like! What do you think?

@hexorx
Copy link
Collaborator

hexorx commented Mar 8, 2013

If you want to add that I think it would be great. It should probably be in addition to the array though. That way we can keep the existing API.

hexorx added a commit that referenced this pull request Mar 8, 2013
added and corrected german translations
@hexorx hexorx merged commit d3820e8 into countries:master Mar 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants